<html>
<head><meta charset="utf-8"><title>Reviewing #71205 fix check_attr() · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Reviewing.20.2371205.20fix.20check_attr().html">Reviewing #71205 fix check_attr()</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="195720804"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Reviewing%20%2371205%20fix%20check_attr%28%29/near/195720804" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Reviewing.20.2371205.20fix.20check_attr().html#195720804">(Apr 29 2020 at 14:49)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/issues/71205" title="https://github.com/rust-lang/rust/issues/71205">#71205</a> is currently assigned to <span class="user-mention silent" data-user-id="119009">eddyb</span> but I think they have other things to do and other PRs to review. I expect <a href="https://github.com/rust-lang/rust/issues/71205" title="https://github.com/rust-lang/rust/issues/71205">#71205</a> to be pretty quick to review, and it would unblock my progress on <a href="https://github.com/rust-lang/rust/issues/69274" title="https://github.com/rust-lang/rust/issues/69274">#69274</a>. There is nothing urgent, but it would be nice if someone had some time to review!</p>



<a name="195748722"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Reviewing%20%2371205%20fix%20check_attr%28%29/near/195748722" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Reviewing.20.2371205.20fix.20check_attr().html#195748722">(Apr 29 2020 at 18:09)</a>:</h4>
<p>Code looks good to me. What kind of code is rejected by this that wasn't before? Only code using <code>#[target_feature]</code>, or other code as well?</p>



<a name="195748845"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Reviewing%20%2371205%20fix%20check_attr%28%29/near/195748845" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Reviewing.20.2371205.20fix.20check_attr().html#195748845">(Apr 29 2020 at 18:10)</a>:</h4>
<p>I think that it concerns attributes that might be rejected</p>



<a name="195748862"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Reviewing%20%2371205%20fix%20check_attr%28%29/near/195748862" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Reviewing.20.2371205.20fix.20check_attr().html#195748862">(Apr 29 2020 at 18:10)</a>:</h4>
<p>Take a look at the <code>codegen_attrs</code></p>



<a name="195748890"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Reviewing%20%2371205%20fix%20check_attr%28%29/near/195748890" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Reviewing.20.2371205.20fix.20check_attr().html#195748890">(Apr 29 2020 at 18:11)</a>:</h4>
<p>For certain attributes, there are additional checks, and errors emitted</p>



<a name="195749586"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Reviewing%20%2371205%20fix%20check_attr%28%29/near/195749586" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Reviewing.20.2371205.20fix.20check_attr().html#195749586">(Apr 29 2020 at 18:17)</a>:</h4>
<p>The only concern I see is that this might cause currently accepted code (on stable) to be rejected, for example malformed <code>#[inline]</code> attributes.</p>



<a name="195749656"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Reviewing%20%2371205%20fix%20check_attr%28%29/near/195749656" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Reviewing.20.2371205.20fix.20check_attr().html#195749656">(Apr 29 2020 at 18:17)</a>:</h4>
<p>Probably not worth starting a crater run just for this, but it's something to keep in mind</p>



<a name="195750286"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Reviewing%20%2371205%20fix%20check_attr%28%29/near/195750286" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Reviewing.20.2371205.20fix.20check_attr().html#195750286">(Apr 29 2020 at 18:22)</a>:</h4>
<p>Code that might break with this PR is code that should be invalid though</p>



<a name="195750422"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Reviewing%20%2371205%20fix%20check_attr%28%29/near/195750422" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Reviewing.20.2371205.20fix.20check_attr().html#195750422">(Apr 29 2020 at 18:24)</a>:</h4>
<p>If it breaks too much code we can also introduce a warning lint to have some transition</p>



<a name="195750468"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Reviewing%20%2371205%20fix%20check_attr%28%29/near/195750468" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Reviewing.20.2371205.20fix.20check_attr().html#195750468">(Apr 29 2020 at 18:24)</a>:</h4>
<p>Yes, but often we've introduced these kinds of breaking changes by starting with a warning period. This doesn't really seem to be worth it in this case though, since the code is trivial to fix (remove the invalid attribute, or fix its syntax).</p>



<a name="195750521"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Reviewing%20%2371205%20fix%20check_attr%28%29/near/195750521" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Reviewing.20.2371205.20fix.20check_attr().html#195750521">(Apr 29 2020 at 18:24)</a>:</h4>
<p>Yeah, seems fine. I've approved it.</p>



<a name="195750528"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Reviewing%20%2371205%20fix%20check_attr%28%29/near/195750528" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Reviewing.20.2371205.20fix.20check_attr().html#195750528">(Apr 29 2020 at 18:24)</a>:</h4>
<p>Crater is running for the beta, if we want to run crater we’ll have to wait quite long <span aria-label="slight smile" class="emoji emoji-1f642" role="img" title="slight smile">:slight_smile:</span></p>



<a name="195750557"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Reviewing%20%2371205%20fix%20check_attr%28%29/near/195750557" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Reviewing.20.2371205.20fix.20check_attr().html#195750557">(Apr 29 2020 at 18:25)</a>:</h4>
<p>Thanks <span class="user-mention" data-user-id="211727">@Jonas Schievink</span>!</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>